Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package marker breaks GitHub actions on using pip>=24.0 #10

Closed
MAKOMO opened this issue Jul 6, 2024 · 2 comments
Closed

Package marker breaks GitHub actions on using pip>=24.0 #10

MAKOMO opened this issue Jul 6, 2024 · 2 comments

Comments

@MAKOMO
Copy link

MAKOMO commented Jul 6, 2024

The pylint GitHub actions of the Artisan project started to fail once pip v24.1 was released. As this did not get fixed by the pip v24.1.1 I reported the issue: pypa/pip#12825

The pip team analyzed the issue and found that it goes back to an open upstream issue in pypa/packaging.

The pip team then added some better error logging which the revealed that the culprit is the yoctopuce package.

Although your marker package seems not contradict any rules (thus I am not an expert on packaging), if possible, it might be good if you could adjust the yoctopuce package marker to prevent this issue from occuring.

@diazona
Copy link

diazona commented Jul 6, 2024

Hey @MAKOMO 👋 The thing about this bug is that the package marker causing the problem doesn't come from the package being depended on, but from the one that has it as a dependency. In this case, the source of the error is where yoctopuce is listed in Artisan's own requirements.txt file. There isn't really anything that yoctopuce can or should do about this.

@MAKOMO
Copy link
Author

MAKOMO commented Jul 7, 2024

Understood. So because the yoctopuce package is the first one being discriminated by sys_platform in our requirements.txt it is the point where pip >24.0 first fails. Thus closing this here and hoping for an upstream fix.

@MAKOMO MAKOMO closed this as completed Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants