Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete json object representation described with model.Property #9

Open
dev-tim opened this issue Apr 2, 2015 · 0 comments
Open

Comments

@dev-tim
Copy link
Contributor

dev-tim commented Apr 2, 2015

Hi guys!

Recently I worked with scala-siren library and figured out that I can't use JSON object in properties property in siren entity, which is quite strange. Here I opened an issue with question kevinswiber/siren#47 where I assume that in properties should be the entiry JSON object.

However, there are some restrictions in siren-scala:

  • In model.Property there are defined basic type fields (String, Bool, Number, etc) but not JsObj and JsVal which can't represent real json.
  • In model.Property I see some kind of duplication to thing we have in for example in play.json or any other json library.

So I'd suggest to get rid of model.Property and just generate JsValue to properties property in siren entity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant