Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregator ansible #1387

Draft
wants to merge 9 commits into
base: 1344-ci-improve-servers-setup
Choose a base branch
from
Draft

Aggregator ansible #1387

wants to merge 9 commits into from

Conversation

samoht9277
Copy link
Collaborator

Aggregator ansible automatic deployment

Description

Description of the pull request changes and motivation.

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@samoht9277 samoht9277 closed this Nov 6, 2024
@samoht9277 samoht9277 reopened this Nov 6, 2024
@samoht9277 samoht9277 changed the base branch from testnet to 1344-ci-improve-servers-setup November 6, 2024 15:34
MauroToscano
MauroToscano requested changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@MauroToscano MauroToscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there be a guide somewhere on how to use this ? Also, how do I test it ?

JuArce
JuArce requested changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@JuArce JuArce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Rust is not necessary
  • Build all ffis is not necessary
  • It is missing to build the aggregator
  • It is missing to upload the configuration files
  • It is missing to add the process to systemd

infra/ansible/playbooks/aggregator.yaml Outdated
pkg:
- pkg-config
- libssl-dev
- gcc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcc is already in setup

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Removing now.

@samoht9277 samoht9277 marked this pull request as draft November 7, 2024 16:12
@samoht9277
Copy link
Collaborator Author

samoht9277 commented Nov 7, 2024 •
edited
Loading 

* Rust is not necessary

* Build all ffis is not necessary

* It is missing to build the aggregator

* It is missing to upload the configuration files

* It is missing to add the process to systemd

Added all of this, my bad!

Documentation is still pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuArce JuArce JuArce requested changes

@MauroToscano MauroToscano MauroToscano requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samoht9277 @MauroToscano @JuArce