New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve metrics on batcher #1370

Open

JulianVentura opened this issue Nov 4, 2024 · 0 comments

Collaborator

JulianVentura commented Nov 4, 2024 •

edited

Loading

Metrics of failed batches: We only take into account a failed batch when the blockchain reverts, but no other failures, for instance an S3 connection failure.
Total proofs: We have a metric which "Total proofs received" which adds all received proofs, without taking into account if they succeed or not. We should provide more information and for this we have to add a new metric. We have two options:

Total proofs failed: Sums all the proofs that were received but failed to be sucessfully included in a batch for some reason
Total proofs sent: Sums up all the proofs that were successfully included in a batch and sent

JulianVentura changed the title ~~Improve metric of failed batches on batcher~~ Improve metrics on batcher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment