Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wido Zaps with support for more vaults #755

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

mazurroman
Copy link

@mazurroman mazurroman commented Sep 30, 2022

Description

Add Zap support for more vaults on Yearn.

Wido brings Zap support for:

  • yvCurve-ibAUD-USDC
  • yvCurve-ibGBP-USDC
  • yvCurve-ibCHF-USDC
  • yvCurve-ibJPY-USDC
  • yvCurve-ibKRW-USDC
  • yvCurve-ibBTC

With Zaps for more vaults to come later.

Related Issue

yearn-sdk PR yearn/yearn-sdk#306

Motivation and Context

Zaps let users deposit any token into a vault instead of just the underlying token. That improves UX and increases deposits and TVL.

Data shows that Zaps contribute to 40% of deposits on Yearn. Having Zap support for all vaults will grow Yearn's overall TVL.

Report: https://twitter.com/widolabs/status/1574762471314915334

How Has This Been Tested?

It was tested locally with the frontend running the yalc'ed SDK.

Left to do

Screenshots (if appropriate):

image

@xgambitox
Copy link
Contributor

Merged this one recently, that might be relevant #764. Please take a look.

* Add widoZapIn and widoZapOut support

* Show correct zap provider

* Fix vault token as input

* Fix vault selection for token w/ partial zap support

* Fix lint
@kernelwhisperer
Copy link

Merged this one recently, that might be relevant #764. Please take a look.

I reviewed the changes in #764, rebased this branch and added this commit f3d2cca. What do you think?

@mazurroman mazurroman marked this pull request as ready for review October 7, 2022 14:19
xgambitox
xgambitox previously approved these changes Oct 27, 2022
@xgambitox xgambitox added the hold Hold pull request label Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Hold pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants