Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modal zap layout on iPhone SE #695

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

huggingbot
Copy link
Contributor

Description

  • Added CSS changes for devices with 400px width or lower
  • 400px is used as that's the point where the text would wrap to the second line
  • Removed padding so that font size can be at 1.3rem, else with the existing padding, font size has to be reduced to 1.2rem
  • Centered the text so that the container's left and right are aligned
  • 341px will be the next point where the text would wrap again

Related Issue

Motivation and Context

  • Better display for iPhone SE users

How Has This Been Tested?

  • Locally by viewing the updated modal layout

Screenshots (if appropriate):

zap

@huggingbot huggingbot changed the title fix: Modal zap layout on iphone se fix: Modal zap layout on iPhone SE May 22, 2022
@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-695.d27dgpz01hmbvx.amplifyapp.com

@turtlemoji
Copy link
Contributor

@huggingbot We should hold this since the layout and style changed in:
#694

@turtlemoji turtlemoji added the hold Hold pull request label May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Hold pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

style: Modal zap breaking on Iphone SE
2 participants