feat: ambire Wallet batch transaction implementation through WalletConnect

[0xdex18]

Allowing Ambire Wallet users to bundle approval transaction with other approval required actions on yearn

[aws-amplify-us-east-1]

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-540.d27dgpz01hmbvx.amplifyapp.com

[turtlemoji]

Hey @0xdex18 , can't you get in contact with onboard js library to implement the wallet?
So we don't have custom logic on the FE, wdyt?

[Ivshti]

hey @turtlemoji - this PR does not implement Ambire

In fact, Ambire is already accessible through WalletConnect

However, it enables automatic batching of approval+action thanks to Ambire's ability to batch transactions, which is impossible to shim at a provider level, therefore not able to be done in onboard

[turtlemoji]

hey @turtlemoji - this PR does not implement Ambire

In fact, Ambire is already accessible through WalletConnect

However, it enables automatic batching of approval+action thanks to Ambire's ability to batch transactions, which is impossible to shim at a provider level, therefore not able to be done in onboard

K! Have a quick look. I'm not really sure about having this custom logic inside vault actions.
Also you are only implementing logic on withdraw, suppy, deposit and not other modals, is this correct/intended for batch calls (withdraw/deposit) right?.

I think @xgambitox will have a better insight here. adding him to fully review it and follow it

[0xdex18]

Hey, as we consider the other modals to be used much less frequently, and as we wanted to keep the PR as small as possible for now, we decided to implementing transaction batching only to the most used modals. Is if fine with you to only use withdraw, supply, deposit for now?