Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WideCombiner] added hashtasble grow log #9830

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

[WideCombiner] added hashtasble grow log #9830

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ydb/library/yql/minikql/comp_nodes/mkql_wide_combine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,16 @@ class TState : public TComputationValue<TState> {
CleanupCurrentContext();
}

bool TasteItWithStateLogging() {
const ui64 initialCapacity = States.GetCapacity();
const bool isNew = TasteIt();
const ui64 currentCapacity = States.GetCapacity();

YQL_LOG_IF(DEBUG, initialCapacity != currentCapacity) << (const void *)this << " Growing states capacity from " << initialCapacity << " to " << currentCapacity;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я не понимаю зачем такой код коммитить в транк. Выглядит как попытка вылечить подземный стук.
У вас есть какая-то проблема с памятью и вы не понимаете куда она девается? А почему тогда в std::vector подобный код не вставить?


return isNew;
}

bool TasteIt() {
Y_ABORT_UNLESS(!ExtractIt);
bool isNew = false;
Expand Down Expand Up @@ -441,7 +451,7 @@ class TSpillingSupportState : public TComputationValue<TSpillingSupportState> {

ETasteResult TasteIt() {
if (GetMode() == EOperatingMode::InMemory) {
bool isNew = InMemoryProcessingState.TasteIt();
bool isNew = InMemoryProcessingState.TasteItWithStateLogging();
Throat = InMemoryProcessingState.Throat;
return isNew ? ETasteResult::Init : ETasteResult::Update;
}
Expand Down
Loading