Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WideCombiner] added hashtasble grow log #9830

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lll-phill-lll
Copy link
Member

Changelog entry

[WideCombiner] added hashtasble grow log
...

Changelog category

  • Improvement

Additional information

...

Copy link

github-actions bot commented Sep 26, 2024

2024-09-26 17:23:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5c5a9ec has started.
2024-09-26 17:23:46 UTC Artifacts will be uploaded here
2024-09-26 17:26:41 UTC ya make is running...
🟡 2024-09-26 19:13:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75456 61348 0 5 14052 51

2024-09-26 19:21:11 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-26 19:32:29 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
292 (only retried tests) 195 0 0 7 90

🟢 2024-09-26 19:32:37 UTC Build successful.
🟢 2024-09-26 19:33:17 UTC ydbd size 8.5 GiB changed* by +38.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c0ce5ac merge: 5c5a9ec diff diff %
ydbd size 9 083 040 816 Bytes 9 083 079 936 Bytes +38.2 KiB +0.000%
ydbd stripped size 490 936 488 Bytes 490 937 064 Bytes +576 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 26, 2024

2024-09-26 17:25:01 UTC Pre-commit check linux-x86_64-release-asan for 5c5a9ec has started.
2024-09-26 17:26:49 UTC Artifacts will be uploaded here
2024-09-26 17:30:31 UTC ya make is running...
🟡 2024-09-26 20:10:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13018 12697 0 104 82 135

🟢 2024-09-26 20:11:30 UTC Build successful.
🟢 2024-09-26 20:12:08 UTC ydbd size 5.7 GiB changed* by +5.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c1eb495 merge: 5c5a9ec diff diff %
ydbd size 6 085 674 208 Bytes 6 085 680 112 Bytes +5.8 KiB +0.000%
ydbd stripped size 1 521 103 152 Bytes 1 521 104 240 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

const bool isNew = TasteIt();
const ui64 currentCapacity = States.GetCapacity();

YQL_LOG_IF(DEBUG, initialCapacity != currentCapacity) << (const void *)this << " Growing states capacity from " << initialCapacity << " to " << currentCapacity;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я не понимаю зачем такой код коммитить в транк. Выглядит как попытка вылечить подземный стук.
У вас есть какая-то проблема с памятью и вы не понимаете куда она девается? А почему тогда в std::vector подобный код не вставить?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants