Ability to batch messages in topic reader #491
Merged
+126
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvoleg
force-pushed
the
topic_batch_messages
branch
from
7aa3545
to
2e6ad26
Compare
|
🌋 Here are results of SLO test for Python SDK over Table Service: |
|
🌋 Here are results of SLO test for Python SDK over Query Service: |
vgvoleg
force-pushed
the
topic_batch_messages
branch
from
24f684c
to
60a4504
Compare
rekby
reviewed
Sep 26, 2024
| @@ -264,7 +264,7 @@ class ReaderStream: | |||
|
|
|||
| _state_changed: asyncio.Event | |||
| _closed: bool | |||
| _message_batches: typing.Deque[datatypes.PublicBatch] | |||
| _message_batches: typing.Dict[int, datatypes.PublicBatch] | |||
There was a problem hiding this comment.
Suggested change
| _message_batches: typing.Dict[int, datatypes.PublicBatch] | |
| _message_batches: typing.Dict[int, datatypes.PublicBatch] # keys are partition session ID |
| @@ -359,29 +359,38 @@ async def wait_messages(self): | |||
| await self._state_changed.wait() | |||
| self._state_changed.clear() | |||
|
|
|||
| def _get_first_batch(self) -> typing.Tuple[int, datatypes.PublicBatch]: | |||
| first_id, batch = self._message_batches.popitem(last=False) | |||
There was a problem hiding this comment.
first_id -> partition_session_id - for understand mean of the number
| def _add_batch_to_queue(self, batch: datatypes.PublicBatch): | ||
| part_sess_id = batch._partition_session.id | ||
| if part_sess_id in self._message_batches: | ||
| self._message_batches[part_sess_id].messages.extend(batch.messages) |
There was a problem hiding this comment.
What about implement _push/_pop method for PublicBatch? it will be easer refctor internals in the future.
| initial_batches = batch_count() | ||
| initial_batch_size = batch_size() if not new_batch else 0 |
There was a problem hiding this comment.
what about invert condition?
Suggested change
| initial_batch_size = batch_size() if not new_batch else 0 | |
| initial_batch_size = 0 if new_batch else batch_size() |
rekby
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information