Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed base64 from contrib #51 #108

Merged
merged 6 commits into from
Mar 26, 2024
Merged

removed base64 from contrib #51 #108

merged 6 commits into from
Mar 26, 2024

Conversation

Shikaree68
Copy link
Contributor

No description provided.

@Shikaree68 Shikaree68 changed the title removed base64 from contrib removed base64 from contrib #51 Mar 22, 2024
Copy link
Collaborator

@GitSparTV GitSparTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Привет. Ошибки билда и конфликты в main появились.
Поправь

@Shikaree68 Shikaree68 force-pushed the base64_#51 branch 12 times, most recently from 45d68d5 to fbac6cd Compare March 25, 2024 11:38
@GitSparTV GitSparTV self-requested a review March 25, 2024 14:10
Copy link
Collaborator

@GitSparTV GitSparTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Привет! Оказалась не самая тривиальная библиотека, ты смог всё подключить.
Нужно убрать из GHA твои отладочные команды, оставил пару заметок заказчику, которые ему могут быть интересны.

.github/actions/prepare_vm/action.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
library/cpp/string_utils/base64/base64.cpp Outdated Show resolved Hide resolved
library/cpp/string_utils/base64/base64.cpp Outdated Show resolved Hide resolved
library/cpp/string_utils/base64/base64.cpp Outdated Show resolved Hide resolved
library/cpp/string_utils/base64/ut/ya.make Outdated Show resolved Hide resolved
.github/actions/prepare_vm/action.yaml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.github/actions/prepare_vm/action.yaml Outdated Show resolved Hide resolved
@Gazizonoki Gazizonoki merged commit cffa8aa into main Mar 26, 2024
1 check passed
@Gazizonoki Gazizonoki deleted the base64_#51 branch March 26, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants