[Filestore] NBSNEBIUS-91: Add ForcedCleanup handle for fs #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yegorskii
reviewed
Jan 30, 2024
cloud/filestore/libs/storage/tablet/tablet_actor_monitoring.cpp
Outdated
Show resolved
Hide resolved
qkrorlqr
reviewed
Feb 1, 2024
cloud/filestore/libs/storage/tablet/tablet_actor_compactionforced.cpp
Outdated
Show resolved
Hide resolved
cloud/filestore/libs/storage/tablet/tablet_actor_compactionforced.cpp
Outdated
Show resolved
Hide resolved
cloud/filestore/libs/storage/tablet/tablet_actor_compactionforced.cpp
Outdated
Show resolved
Hide resolved
cloud/filestore/libs/storage/tablet/tablet_actor_compactionforced.cpp
Outdated
Show resolved
Hide resolved
cloud/filestore/libs/storage/tablet/tablet_actor_compactionforced.cpp
Outdated
Show resolved
Hide resolved
yegorskii
previously approved these changes
Feb 2, 2024
qkrorlqr
reviewed
Feb 2, 2024
cloud/filestore/libs/storage/tablet/tablet_actor_compactionforced.cpp
Outdated
Show resolved
Hide resolved
qkrorlqr
approved these changes
Feb 2, 2024
yegorskii
approved these changes
Feb 2, 2024
debnatkh
added a commit
that referenced
this pull request
Feb 2, 2024
* [Filestore] NBSNEBIUS-91: Add ForcedCleanup handle for fs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a mechanism that forcefully compacts all ranges present in the fs. In this PR a forced cleanup is introduced, which similarly forcefully runs cleanup operation on all ranges. No new transactions are introduced – ForcedCompaction request is extended with a enum that specifies if compaction or a cleanup is to be performed on the range.