Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make forbidden dependency check for model dirs #267

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

drbasic
Copy link
Collaborator

@drbasic drbasic commented Jan 27, 2024

Добавил проверки в каталогах model что они не зависят от contrib/ydb
теперь если попытаться заинклюить чтонить лишнего - будет ошибка сборки примерно такого содержания:

Error[-WBadDep]: in $B/cloud/blockstore/libs/storage/volume/model/libstorage-volume-model.a: forbids direct or indirect dependency to module $B/contrib/ydb/library/yql/core/expr_nodes_gen/gen/libpy3core-expr_nodes_gen-gen.a via CHECK_DEPENDENT_DIRS
    $B/cloud/blockstore/libs/storage/volume/model/libstorage-volume-model.a -> $B/cloud/blockstore/libs/kikimr/libblockstore-libs-kikimr.a
    $B/cloud/blockstore/libs/kikimr/libblockstore-libs-kikimr.a -> $B/cloud/storage/core/libs/kikimr/libcore-libs-kikimr.a
    $B/cloud/storage/core/libs/kikimr/libcore-libs-kikimr.a -> $B/contrib/ydb/core/mind/libydb-core-mind.a
    $B/contrib/ydb/core/mind/libydb-core-mind.a -> $B/contrib/ydb/core/engine/minikql/libcore-engine-minikql.a
    $B/contrib/ydb/core/engine/minikql/libcore-engine-minikql.a -> $B/contrib/ydb/core/client/minikql_compile/libcore-client-minikql_compile.a
    $B/contrib/ydb/core/client/minikql_compile/libcore-client-minikql_compile.a -> $B/contrib/ydb/core/engine/libydb-core-engine.a
    $B/contrib/ydb/core/engine/libydb-core-engine.a -> $B/contrib/ydb/library/mkql_proto/libydb-library-mkql_proto.a
    $B/contrib/ydb/library/mkql_proto/libydb-library-mkql_proto.a -> $B/contrib/ydb/library/yql/providers/common/codec/libproviders-common-codec.a
    $B/contrib/ydb/library/yql/providers/common/codec/libproviders-common-codec.a -> $B/contrib/ydb/library/yql/providers/common/mkql/libproviders-common-mkql.a
    $B/contrib/ydb/library/yql/providers/common/mkql/libproviders-common-mkql.a -> $B/contrib/ydb/library/yql/core/liblibrary-yql-core.a
    $B/contrib/ydb/library/yql/core/liblibrary-yql-core.a -> $B/contrib/ydb/library/yql/core/expr_nodes/libyql-core-expr_nodes.a
    $B/contrib/ydb/library/yql/core/expr_nodes/libyql-core-expr_nodes.a -> $B/contrib/ydb/library/yql/core/expr_nodes_gen/gen/gen
    $B/contrib/ydb/library/yql/core/expr_nodes_gen/gen/gen -> $B/contrib/ydb/library/yql/core/expr_nodes_gen/gen/libpy3core-expr_nodes_gen-gen.a```

@drbasic drbasic requested a review from qkrorlqr January 27, 2024 07:40
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 783d61e.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
4700 4628 0 0 0 72

@drbasic drbasic merged commit 6b0b25d into main Jan 29, 2024
5 checks passed
@drbasic drbasic deleted the users/drbasic/deny-deps/0 branch January 29, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants