fix: vhost-server aio backend was incorrectly batching ios #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After refactoring the `Batch` array of iocb was incorrectly shared between different vhost queues. This lead to memory corruption which was not detected since tests were running with only 1 vhost queue configured. ``` qemu ... -device vhost-user-blk-pci,chardev=vhost0,id=vhost-user-blk0,num-queues=1 ```
sharpeye
approved these changes
Jan 25, 2024
komarevtsev-d
approved these changes
Jan 25, 2024
budevg
added a commit
that referenced
this pull request
Jan 25, 2024
After refactoring the `Batch` array of iocb was incorrectly shared between different vhost queues. This lead to memory corruption which was not detected since tests were running with only 1 vhost queue configured. ``` qemu ... -device vhost-user-blk-pci,chardev=vhost0,id=vhost-user-blk0,num-queues=1 ```
budevg
added a commit
that referenced
this pull request
Jan 26, 2024
After refactoring the `Batch` array of iocb was incorrectly shared between different vhost queues. This lead to memory corruption which was not detected since tests were running with only 1 vhost queue configured. ``` qemu ... -device vhost-user-blk-pci,chardev=vhost0,id=vhost-user-blk0,num-queues=1 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After refactoring the
Batcharray of iocb was incorrectly shared betweendifferent vhost queues. This lead to memory corruption which was not detected
since tests were running with only 1 vhost queue configured.