Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-2086: introduce IFileIOServiceProvider #2117

Merged
merged 2 commits into from
Sep 25, 2024
Merged

issue-2086: introduce IFileIOServiceProvider #2117

merged 2 commits into from
Sep 25, 2024

Conversation

sharpeye
Copy link
Collaborator

@sharpeye sharpeye commented Sep 23, 2024 •
edited
Loading

@sharpeye sharpeye added the blockstore Add this label to run only cloud/blockstore build and tests on PR label Sep 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 222517e.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3285 3284 0 1 0 0

@sharpeye sharpeye force-pushed the users/sharpeye/issue-2086-multi-aio branch from 222517e to 26c18eb Compare September 24, 2024 11:11
@sharpeye sharpeye changed the title issue-2086: introduce IFileIOServiceFactory issue-2086: introduce IFileIOServiceProvider Sep 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 26c18eb.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3285 3285 0 0 0 0

@sharpeye sharpeye force-pushed the users/sharpeye/issue-2086-multi-aio branch from 26c18eb to 450c6aa Compare September 24, 2024 12:05
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 450c6aa.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3284 3284 0 0 0 0

@sharpeye sharpeye force-pushed the users/sharpeye/issue-2086-multi-aio branch from 450c6aa to 112d2ef Compare September 24, 2024 12:42
@sharpeye sharpeye force-pushed the users/sharpeye/issue-2086-multi-aio branch from 112d2ef to bb3e226 Compare September 24, 2024 12:57
@sharpeye sharpeye marked this pull request as ready for review September 24, 2024 13:00
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit bb3e226.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3285 3285 0 0 0 0

komarevtsev-d
komarevtsev-d previously approved these changes Sep 24, 2024
View reviewed changes
@tpashkin
Copy link
Collaborator

А правда же, что у тебя уже написан код настоящих реализаций и эти интерфейсы не придётся переделывать следующим коммитом?

@budevg budevg self-requested a review September 24, 2024 15:37
@sharpeye
Copy link
Collaborator Author

А правда же, что у тебя уже написан код настоящих реализаций и эти интерфейсы не придётся переделывать следующим коммитом?

Это и есть настоящая реализация. В следующем PR будет использование этого добра, интерфейсы не меняются.

@sharpeye sharpeye force-pushed the users/sharpeye/issue-2086-multi-aio branch from 5d1eb08 to bb3e226 Compare September 25, 2024 08:25
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 0e046fb.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3285 3285 0 0 0 0

@sharpeye sharpeye merged commit f2598d8 into main Sep 25, 2024
11 of 12 checks passed
@sharpeye sharpeye deleted the users/sharpeye/issue-2086-multi-aio branch September 25, 2024 09:02
sharpeye added a commit that referenced this pull request Sep 27, 2024
@sharpeye
issue-2086: introduce IFileIOServiceProvider (#2117)
b442520 
* issue-2086: introduce IFileIOServiceProvider
sharpeye added a commit that referenced this pull request Sep 27, 2024
@sharpeye
merge to stable-23-3 (#2149)
a8fbc7d 
* issue-2086: introduce IFileIOServiceProvider (#2117)

* issue-2086: use multiple aio services (#2126)

* retrying EAGAIN from io_setup in vhost-server (#2143)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komarevtsev-d komarevtsev-d komarevtsev-d approved these changes

@budevg budevg budevg approved these changes

Assignees
No one assigned
Labels
blockstore Add this label to run only cloud/blockstore build and tests on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sharpeye @tpashkin @budevg @komarevtsev-d