23-3 local disk with encryption #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Show keyhash on monpage * Fix review issues
* Pass encryption key info to external-vhost server * Fix and tests * Fix review issues
* Small fixes * Use unique_ptr for memory management * Fix creation call * Fix review issues
* VHost aio backend encryption * Log message on error * Tests in server_ut.cpp * Write zero blocks * Return VHD_BDEV_IOERR on enryption/decryption error * Abort process when can't get encryption key * Tests * Fix review issues * Add test and clang-format * Fix ASAN * Remove unnecessary changes
* Use backoff delay when restart external-vhost-server * Make constants * Do not write that we will restart if we are not going to do it
* Write encrypted zero-block * Stats about encryptor errors and generated zero blocks * Use constexpr * Transfer critical events to NBS * Fix typo * Limit crit event storage size * Fix review issues * Fix test
budevg
approved these changes
Aug 12, 2024
EvgeniyKozev
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.