NBSNEBIUS-36: fix endpoint storage reading #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharpeye
previously approved these changes
Jan 15, 2024
debnatkh
previously approved these changes
Jan 15, 2024
sanek325
force-pushed
the
NBSNEBIUS-36-strip
branch
from
58b5505
to
bed7ab4
Compare
debnatkh
approved these changes
Jan 15, 2024
NewBediver
approved these changes
Jan 15, 2024
sanek325
added a commit
that referenced
this pull request
Jan 15, 2024
Co-authored-by: Aleksandr Rigachnyi <[email protected]>
sanek325
added a commit
that referenced
this pull request
Jan 15, 2024
Co-authored-by: Aleksandr Rigachnyi <[email protected]>
sanek325
added a commit
that referenced
this pull request
Jan 16, 2024
* remove useless kms tests (#114) Co-authored-by: Aleksandr Rigachnyi <[email protected]> * NBSNEBIUS-36: use tmp file for endpoint storage (#133) Co-authored-by: Aleksandr Rigachnyi <[email protected]> * fix endpoint storage reading (#147) Co-authored-by: Aleksandr Rigachnyi <[email protected]> --------- Co-authored-by: Aleksandr Rigachnyi <[email protected]>
qkrorlqr
pushed a commit
that referenced
this pull request
Jan 17, 2024
Co-authored-by: Aleksandr Rigachnyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
мы для каждого ендпоинта создаем файл в который кладем запрос TStartEndpointRequest в бинарном виде.
При старте nbs мы вычитываем запросы из файлов. Проблема в том что при вычитывании мы делали Strip (видимо копипаста откуда-то), из-за этого если запрос в бинарном виде начинался или заканчивался с пробелов или переносов строк, то он не мог распарситься