Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Disk Manager]: Do not hang on mkfs.ext4 in sync tests #121

Closed

Conversation

jkuradobery
Copy link
Collaborator

Add -F parameter to the sync tests in order to avoid hanging on the disk reuse.

Add -F parameter to the sync tests in order to avoid hanging on the disk reuse.
@jkuradobery
Copy link
Collaborator Author

There is no point in using the -F key. The explaination is the following:
mkfs.ext4 is pretty much mke2fs. And it checks for the file-system being present and asks for input afterwards.
https://github.com/tytso/e2fsprogs/blob/master/misc/util.c#L96
In "right" tests we did not create pseudo-terminal, so mke2fs just creates the filesystem. To avoid affecting "right" tests, we should just change our ssh client implementation by adding the -T parameter. Will abandon this PR and create a new one.
@qkrorlqr @WilyTiger @SvartMetal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants