Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filestore] Filesystem destruction should fail not only if there are active sessions, but if there are orphan sessions as well #2434

Open
qkrorlqr opened this issue Nov 6, 2024 · 0 comments
Assignees
Labels
filestore Add this label to run only cloud/filestore build and tests on PR

Comments

@qkrorlqr
Copy link
Collaborator

qkrorlqr commented Nov 6, 2024

Here

for (const auto& session: Impl->Sessions) {
we iterate only over active sessions. We should iterate over both active and orphan sessions. Since filesystem destruction logic uses DescribeSessions, it will automatically guarantee that oprhan sessions will prevent filesystem destruction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filestore Add this label to run only cloud/filestore build and tests on PR
Projects
None yet
Development

No branches or pull requests

1 participant