fix: acceptance test failure (#2148)

1. disable disk auto-detach to debug test after failure 2. use wait_for_block_device_to_appear implementation from helpers
ydb-platform · Sep 27, 2024 · 98ac178 · 98ac178
1 parent 4e0d085
commit 98ac178
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/cloud/disk_manager/test/acceptance/test_runner/lib/helpers.py b/cloud/disk_manager/test/acceptance/test_runner/lib/helpers.py
@@ -37,9 +37,10 @@ def wait_for_block_device_to_appear(
     disk_id: str,
     module_factory,
     ssh_key_path: str | None = None,
-) -> str:
-    device_to_id_mapper = VirtualDevicesToIdMapper(ip, module_factory, ssh_key_path)
-    return device_to_id_mapper.wait_for_disk_to_appear(disk_id)
+):
+    device_name = f'/dev/disk/by-id/virtio-{disk_id}'
+    helpers = module_factory.make_helpers(False)
+    helpers.wait_for_block_device_to_appear(ip, device_name, ssh_key_path=ssh_key_path)
 
 
 class VirtualDevicesToIdMapper:

diff --git a/cloud/disk_manager/test/acceptance/test_runner/lib/instance_policy.py b/cloud/disk_manager/test/acceptance/test_runner/lib/instance_policy.py
@@ -75,7 +75,8 @@ def obtain(self) -> Ycp.Instance:
 
     @contextmanager
     def attach_disk(self, disk: Ycp.Disk):
-        with self._ycp.attach_disk(self._instance, disk):
+        # Temprorary disable autodetach to debug acceptance test failure
+        with self._ycp.attach_disk(self._instance, disk, None, False):
             yield wait_for_block_device_to_appear(
                 self._instance.ip,
                 disk.id,