Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] Update CI config #4240

Merged
merged 1 commit into from
Aug 7, 2024
Merged

[READY] Update CI config #4240

merged 1 commit into from
Aug 7, 2024

Conversation

bstaletic
Copy link
Collaborator

@bstaletic bstaletic commented Jun 20, 2024

PR Prelude

Thank you for working on YCM! :)

Please complete these steps and check these boxes (by putting an x inside
the brackets) before filing your PR:

  • I have read and understood YCM's CONTRIBUTING document.
  • I have read and understood YCM's CODE_OF_CONDUCT document.
  • I have included tests for the changes in my PR. If not, I have included a
    rationale for why I haven't.
  • I understand my PR may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Why this change is necessary and useful

This is similar to ycm-core/ycmd#1746


This change is Reviewable

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (52618ae) to head (a8018f9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4240   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files          37       37           
  Lines        4780     4780           
=======================================
  Hits         4295     4295           
  Misses        485      485           

@bstaletic bstaletic force-pushed the new-ci branch 2 times, most recently from e140767 to 0651899 Compare June 20, 2024 06:07
Copy link
Member

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 1 of 2 LGTMs obtained

Copy link
Member

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @bstaletic)

@bstaletic
Copy link
Collaborator Author

This one fixes the CI failures. Merging.

@bstaletic bstaletic added the Ship It! Manual override to merge a PR by maintainer label Aug 7, 2024
@bstaletic bstaletic merged commit 5d8a7fe into ycm-core:master Aug 7, 2024
11 of 12 checks passed
Copy link
Contributor

mergify bot commented Aug 7, 2024

Thanks for sending a PR!

@bstaletic bstaletic deleted the new-ci branch August 7, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ship It! Manual override to merge a PR by maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants