Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kikit separate: net renaming breaks substitution vars like ${SHORT_NET_NAME(n)} #687

Open
3 tasks done
dlitz opened this issue May 14, 2024 · 1 comment
Open
3 tasks done

Comments

@dlitz
Copy link

dlitz commented May 14, 2024

Prerequisites

  • I have read FAQ
  • I have searched existing issues (including closed ones)
  • I use KiKit at least version 1.5.1 (older version are not supported)

KiKit version

1.5.1+11.g56f018a

KiCAD version

8.0.2

Operating system

Debian bookworm (flatpak)

Description

kikit separate adds prefixes to all netnames (e.g. "Board_0-GND"), which garbles use of substitution vars like ${SHORT_NET_NAME(1)} in footprints when they refer to global netnames.

Modifying netnames might be necessary when panelizing, but there should be no need for it when simply splitting up a PCB, and it breaks footprints that put netnames on the silkscreen layer.

Before using kikit separate

image

After using kikit separate:

Note how the GND and VDD labels are made illegible on J1:

X1 X2
image Screenshot_20240514_002122

Schematics

Root

Screenshot_20240514_001146

subckt.kicad_sch

Screenshot_20240514_001213

Steps to Reproduce

  • Unarchive and open project demo-kikit-separate-netname-bug.zip
    • Source PCB file: demo-kikit-separate-netname-bug.kicad_pcb
    • Generated PCB files: generated-X1.kicad_pcb, generated-X2.kicad_pcb
  • To rebuild, edit and use the included Makefile, or run:
kikit separate --source "annotation; ref: X1" demo-kikit-separate-netname-bug.kicad_pcb generated-X1.kicad_pcb
kikit separate --source "annotation; ref: X2" demo-kikit-separate-netname-bug.kicad_pcb generated-X2.kicad_pcb
@dlitz dlitz changed the title "kikit separate" breaks substitution vars like ${SHORT_NET_NAME(n)} kikit separate: net renaming breaks substitution vars like ${SHORT_NET_NAME(n)} May 24, 2024
@yaqwsx
Copy link
Owner

yaqwsx commented Jul 18, 2024

Thank you for noting this. I wasn't aware you are able to reference net names in labels in KiCAD. Ideally, we should bake the net names for panelization, however, this seems a little more involved than I expected.

Therefore I disabled net renaming in board separation in 5fe407f as it should solve most of the problem we observe. The "ultimate" fix will take some time to implement and test properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants