Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix syntax error in workflow file #763

Closed
wants to merge 1 commit into from

Conversation

perlpunk
Copy link
Member

See also #588

@perlpunk perlpunk mentioned this pull request Nov 11, 2023
@nitzmahone
Copy link
Member

@perlpunk We actually need to re-add the rest of the 3.8 x86_64 job for Windows where that line came from- I got over-zealous with the "scissors" when I was removing EOL Python matrix entries, but since that's one of the commented out parts of the CI copy of the workflow, it didn't break. I can just add a commit to this PR if you'd rather, or whatever...

Bigger picture: I've got a working dynamic matrix generator that eliminates the need for the two copies of the workflow altogether. With that, we just use whatever criteria we want to dynamically omit jobs that aren't applicable/possible in a given context (eg, the jobs that require the self-hosted Apple Silicon Mac runners and the slow/emulated jobs). It's a major bummer that GHA still doesn't provide any supported mechanism for doing this (and also to be able to represent the omitted jobs), but at least we have a solution now that can work.

@perlpunk
Copy link
Member Author

Well, it broke for me: https://github.com/perlpunk/pyyaml/actions/runs/6835080303
I saw Invalid workflow file: .github/workflows/manual_artifact_build.yaml#L353.
But if you want to fix it differently, I'll just close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants