Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Parameter to Remove Extraneous Files on Upload #202

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sthm
Copy link

@sthm sthm commented Nov 26, 2015

This commit adds two parameters (--delete, --delete-excluded) to the upload
command. When specified, files that have been removed locally will be removed
(more precisely will be moved to the trash) on the server as well.

This functionality is usefull to keep local and remote conent in sync. It mimics
the behaviour of the respective rsync commands.

This commit adds two parameters (--delete, --delete-excluded) to the upload
command. When specified, files that have been removed locally will be removed
(more precisely will be moved to the trash) on the server as well.

This functionality is usefull to keep local and remote conent in sync. It mimics
the behaviour of the respective rsync commands.
@stevenolen
Copy link

@sthm 👍 I just came to the repo to see if this was a future feature request and found this PR! awesome!

I think this is actually the same request as #86?

@sthm
Copy link
Author

sthm commented Nov 27, 2015

Glad you like it!

It indeed seems to be related to the feature request you've mentioned. I wasn't aware of it, though, I just happened to have some free time and was missing the feature from the cli ;)

Regards,
Steffen

On November 26, 2015 9:00:20 PM GMT+01:00, Steve Nolen [email protected] wrote:

@sthm 👍 I just came to the repo to see if this was a future feature
request and found this PR! awesome!

I think this is actually the same request as #86?


Reply to this email directly or view it on GitHub:
#202 (comment)

@yadayada
Copy link
Owner

Two things:

  1. This kind of deletion will trash nodes that are also hard-linked to other parents, effectively removing them from multiple folders. I know ACDFuse does the same, but the CLI part of acd_cli still respects multi-parent nodes AFAIR.
  2. Would you kindly add these options to the download action, too?

@yadayada yadayada added the CLI label Nov 27, 2015
@beam
Copy link

beam commented Dec 1, 2015

@sthm 👍 great feature

@sthm
Copy link
Author

sthm commented Dec 2, 2015

  1. The same mechanism is used by trash_action and remove_child_action. I'm happy to change this behavior, if you point me to some code that I can use instead.
  2. Sure! Is there some way I can add the commit to this pull request or do I need to open a new one?

@yadayada
Copy link
Owner

yadayada commented Dec 2, 2015

  1. I meant that it should be checked whether the node has a single parent or not. If it has a) a single parent, the node may be safely trashed, and if it has b) multiple parents, it should be removed from the particular parent only.
  2. The pull request refers to the HEAD of your branch, so it should auto-update if you make a new commit to sthm:master, hopefully.

@JigSawFr
Copy link

JigSawFr commented Dec 8, 2015

Nice feature to add 👍

@philrz
Copy link

philrz commented Mar 22, 2016

I had a need for this functionality as well and found this PR. Since it wasn't merged, I tried my hand at applying the diff to the current head of master but found the changes were no longer compatible due to the changes to "rework NodeCache" (commit 8997b8c). I took a shot at making the necessary changes and they seem to work ok, at least with my data. I don't claim total understanding of all the dependent code, though, so it could surely use a look from someone more familiar with the code base. If anyone wants to advance this work, feel free to use what I've got at https://github.com/philrz/acd_cli as a basis.

@HeroCC
Copy link

HeroCC commented May 15, 2016

Any update on this being merged? It is a feature that would be immensely helpful with my environment.

@deeperton
Copy link

Please merge it.

@gryphonmyers
Copy link

Waaaaant

@k4kfh
Copy link

k4kfh commented Feb 26, 2017

I would love to see this merged. Having deleted files put into the trash would be awesome, as I currently back up photos from my FreeNAS appliance to Prime Photos using acd_cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants