Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Customize on Singular Post has confusing behaviour #283

Open
BinaryMoon opened this issue Sep 19, 2016 · 5 comments
Open

Customize on Singular Post has confusing behaviour #283

BinaryMoon opened this issue Sep 19, 2016 · 5 comments
Labels

Comments

@BinaryMoon
Copy link

I think the behaviour on single blog posts/ pages for the 'customize' button is confusing. It takes me to the edit post section of the customize posts control, rather than the customizer which is where I wanted to go.

I think it would be more logical to change the location of the 'edit post' link, rather than the customize link?

@westonruter
Copy link
Contributor

@BinaryMoon Thanks for the feedback (sorry for the delay). Actually this was a requested feature in #105 via #236.

There is another issue I've raised in #34 which goes further to filter the edit_post_link() on the frontend to link to the customizer section for the given post, in the same way that the admin bar “Customize” link is now pointing to the post section (via #236). My thought was that it would be very controversial and largely over-opinionated to link the frontend edit_post_link() to the customizer instead of to the edit post screen. At least when they click “Customize” the user is expecting to go to into the customizer. Several have raised that they expected the link to autofocus on the post section rather than remain on the root, and I myself found myself wanting this feature when I was using the plugin as a user. Perhaps the behavior of how Customize Posts affects the admin bar Customize link and the edit_post_link should be filtered to allow that behavior to be customized, but I think the default decision to have the Customize link autofocus to the post section makes sense.

@BinaryMoon
Copy link
Author

I was expecting to go the customizer make to make some theme related changes and ended up on the edit posts section. My expectation of clicking the customize button is that it would always behave the same way.

I can however see the benefit of deep linking the customizer so perhaps it would be clearer if you renamed the 'Customize' button to 'Customize Post'?

@westonruter
Copy link
Contributor

That's a good idea. Only one problem I can see there: translations. Per #237 we can't introduce a translation string like Customize %s where the placeholder is the post type's singular_name. A language may require some verb-object agreement in some linguistic features, and so we have to rely on pre-existing labels for the registered post type, or use something entirely generic like “Customize The Thing” 😄

@BinaryMoon
Copy link
Author

Can't people translate it as '%s customizer' or do you mean that the value of %s would need to be something other than the singular_name?

I shall have a think, maybe there's something else that could be done.

@westonruter
Copy link
Contributor

See https://core.trac.wordpress.org/ticket/37895

The word “Customizer” may combine differently with “Posts” and “Pages” in other languages, so we can't assume it can be used in a phrase like that. See agreement (linguistics).

Potentially we could get around it by adding a little colon which could workaround this issue with a translation string like Customize: %s, which would yield:

  • Customize: Post
  • Customize: Page
  • Customize: Testimonial

I'm not 100% sure this would be safe for translation purposes. @afercia what do you think?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants