Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when clicking several times on More Results #285

Closed
ane-gabriela opened this issue Sep 12, 2024 · 0 comments · Fixed by #306
Closed

Error when clicking several times on More Results #285

ane-gabriela opened this issue Sep 12, 2024 · 0 comments · Fixed by #306
Assignees
@snazare @Farcasut
Labels
drawio24.5.5 ToSchedule Type: Bug
Milestone
1.21.1

Comments

@ane-gabriela
Copy link

Steps to reproduce:

  1. Edit an existing diagram
  2. Type a word in the "Search Shapes" box ex. "clipart" or "arrow"
  3. Press Enter on the keyboard to start the search
  4. Click on the "More Results" button More Results
  5. Click several more times on the "More Results" button to reach the end of the list

Expected results: The full list of results is shown.

Actual results: Once the user clicks on the "More Results" button to reach the end of the list the following message box appears

End

Environment: Windows 11, XWiki 15.10.10, Chrome 128, Diagram Application (Pro) version 1.21-rc-1

NOTE: Tested on XWiki 15.10.10 with Diagram Application (Pro) 1.20.6 and the issue doesn't reproduce.
Farcasut added a commit to Farcasut/application-diagram-fork that referenced this issue Nov 3, 2024
@Farcasut
ror when clicking multiple times on "More Results" xwikisas#285
1d721fc 
* In version 22.0.0, Draw.io updated the way it computes the icon path. It now relies on a new global variable called DRAWIO_SERVER_URL, which is based on the current server address. Due to this change, requests intended for Draw.io are mistakenly made locally instead of to the external Draw.io server.

https://github.com/jgraph/drawio/blame/acd938b1e42cff3be3b629e6239cdec9a9baddcc/src/main/webapp/js/diagramly/Init.js#L51

https://github.com/jgraph/drawio/blame/acd938b1e42cff3be3b629e6239cdec9a9baddcc/src/main/webapp/js/diagramly/Init.js#L25
Farcasut added a commit that referenced this issue Nov 8, 2024
@Farcasut
Error when clicking several times on More Results #285 (#306)
82b3dfc 
* In version 22.0.0, drawio updated the way it computes the icon path. It now relies on a new global variable called DRAWIO_SERVER_URL, which is based on the current server address. Due to this change, requests intended for drawio are mistakenly made locally instead of to the external drawio server.

https://github.com/jgraph/drawio/blame/acd938b1e42cff3be3b629e6239cdec9a9baddcc/src/main/webapp/js/diagramly/Init.js#L51

https://github.com/jgraph/drawio/blame/acd938b1e42cff3be3b629e6239cdec9a9baddcc/src/main/webapp/js/diagramly/Init.js#L25
@Farcasut Farcasut added this to the 1.21.1 milestone Nov 8, 2024
@Farcasut Farcasut closed this as completed Nov 8, 2024
@Farcasut Farcasut linked a pull request Nov 8, 2024 that will close this issue
Error when clicking several times on More Results #285 #306
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snazare snazare

@Farcasut Farcasut

Labels
drawio24.5.5 ToSchedule Type: Bug
Projects
Pro Apps Roadmap October - November 2024
Status: Done
Milestone
1.21.1
Development

Successfully merging a pull request may close this issue.

Error when clicking several times on More Results #285 Farcasut/application-diagram-fork
3 participants
@snazare @ane-gabriela @Farcasut