Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Diagram document is created too soon #280

Closed
rstavro opened this issue Aug 16, 2024 · 1 comment
Closed

The Diagram document is created too soon #280

rstavro opened this issue Aug 16, 2024 · 1 comment

Comments

@rstavro
Copy link

rstavro commented Aug 16, 2024

If the save button has custom handlers to freeze the save action (for background checks or confirmation, as example), the Diagram document gets created before unfreezing / executing the the save action.

When looking at the requests, I noticed that there are some separate upload ones that attach a PNG / SVG file to the Diagram document.

Marius explained to me that there are 3 versions of the diagram document generated at save and that the current approach is not OK. Instead of actual attachments, temporary attachments should be used. The Diagram app should make 2 requests first, to save the temporary PNG and SVG files and then, at save, the two files should be indicated as temporary attachments that must be saved along with the content of the diagram

@ChiuchiuSorin
Copy link

A similar issue had already been solved and released in application diagram version 1.20: #252.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants