Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in the diagram aren't updated when the linked pages are moved/renamed #245

Closed
ane-gabriela opened this issue Jul 26, 2023 · 4 comments

Comments

@ane-gabriela
Copy link

Steps to reproduce:

  1. Create a page eg. Page 1
  2. Create a diagram with shapes that contain text
  3. Add a link on one of the text to Page 1
  4. Move / Rename "Page 1" to "QA Test"
  5. Access the diagram
  6. Observe the link to the page
    ResultAfterChange
  7. Click on the link

Expected results: The link to the page is updated with the new location and/or name. Related to #110

Actual results: The link to the page remains the same, it's not updated, which makes the user to be redirected to a non existing page.

WhenClicked

Environment: Windows 11, XWiki 14.10.10, Chrome 114, Diagram Application (Pro) 1.19

@ane-gabriela ane-gabriela added this to the 1.19.1 milestone Jul 26, 2023
@oanalavinia oanalavinia modified the milestones: 1.19.1, 1.19.2 Oct 5, 2023
@oanalavinia oanalavinia modified the milestones: 1.19.2, 1.19.3, 1.19.4 Nov 13, 2023
@oanalavinia oanalavinia modified the milestones: 1.19.4, 1.19.5 Nov 21, 2023
@oanalavinia oanalavinia removed this from the 1.19.5 milestone Jan 31, 2024
@ane-gabriela
Copy link
Author

Issue reproducing on Windows 11, Chrome 125. Cloud XWiki 15.10.8, Diagram Application (Pro) 1.20.4

@snazare snazare removed their assignment Jun 6, 2024
@oanalavinia oanalavinia self-assigned this Jun 10, 2024
@snazare snazare assigned Farcasut and unassigned oanalavinia Aug 6, 2024
@snazare snazare removed the ToSchedule label Aug 6, 2024
@claudiuion117
Copy link

I reproduced this issue on Firefox 128.0.3. , XWiki 15.10.8. on premise with Diagram App Pro 1.20.4. and on XWiki version 15.10.11. (LTS version)

Farcasut added a commit to Farcasut/application-diagram-fork that referenced this issue Sep 4, 2024
…renamed xwikisas#245

 * Updated the code to save xwiki backlinks again
@ane-gabriela
Copy link
Author

Reproducing on Windows 11, XWiki 15.10.10, Chrome 128, Diagram Application (Pro) version 1.21-rc-1

Farcasut added a commit to Farcasut/application-diagram-fork that referenced this issue Oct 8, 2024
@Farcasut
Copy link

Farcasut commented Oct 23, 2024

This issue has two causes:

Each of them breaks the update links functionality because of a different reasons (one can be reproduced starting with Diagram versions >= 1.20.3, and the other with XWiki versions >= 14.8. )
Both issues need to be closed for fixing the update links feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

5 participants