Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't build on Linux 4.15 #36

Open
unixfox opened this issue Feb 12, 2018 · 4 comments
Open

Doesn't build on Linux 4.15 #36

unixfox opened this issue Feb 12, 2018 · 4 comments

Comments

@unixfox
Copy link

unixfox commented Feb 12, 2018

I can't build the mt7610u module on Linux kernel 4.15.2.
Here are the logs:

<command-line>:0:0: note: this is the location of the previous definition
/var/lib/dkms/mt7610u_sta/1.0/build/os/linux/../../os/linux/rt_linux.c: In function '__RTMP_OS_Init_Timer':
/var/lib/dkms/mt7610u_sta/1.0/build/os/linux/../../os/linux/rt_linux.c:117:3: error: implicit declaration of function 'init_timer'; did you mean 'init_timers'? [-Werror=implicit-function-declaration]
   init_timer(pTimer);
   ^~~~~~~~~~
   init_timers
/var/lib/dkms/mt7610u_sta/1.0/build/os/linux/../../os/linux/rt_linux.c:118:9: error: 'OS_NDIS_MINIPORT_TIMER {aka struct timer_list}' has no member named 'data'
   pTimer->data = (unsigned long)data;
         ^~
/var/lib/dkms/mt7610u_sta/1.0/build/os/linux/../../os/linux/rt_linux.c:119:20: error: assignment from incompatible pointer type [-Werror=incompatible-pointer-types]
   pTimer->function = function;
                    ^

It's because with the Linux version 4.15-rc1, the old interface init_timer() is no longer available:

With version 4.15-rc1, conversion to new timer interface is finished and
old interface using init_timer() is no longer available. Convert both users
to new one.

-mkubecek

@xtknight Can you look at this?

@unixfox unixfox changed the title Can't build on Linux 4.15 Doesn't build on Linux 4.15 Feb 12, 2018
@Viish
Copy link
Contributor

Viish commented Mar 7, 2018

Hi,

Check out my PR that fixes it: #37

Best regards,

@unixfox
Copy link
Author

unixfox commented Mar 8, 2018

@Viish I got a working build with your patch!
Merci!

@unixfox unixfox closed this as completed Mar 8, 2018
@Segaja
Copy link

Segaja commented Mar 9, 2018

Why close this bug if the related PR was not merged yet?

@unixfox unixfox reopened this Mar 9, 2018
@tinhtrilac
Copy link

same. I tried it on Ubuntu 18.04 still get error when make
cc1: some warnings being treated as errors scripts/Makefile.build:332: recipe for target '/home/johny/Downloads/mt7610u-linksys-ae6000-wifi-fixes-master/os/linux/../../os/linux/rt_linux.o' failed make[2]: *** [/home/johny/Downloads/mt7610u-linksys-ae6000-wifi-fixes-master/os/linux/../../os/linux/rt_linux.o] Error 1 Makefile:1552: recipe for target '_module_/home/johny/Downloads/mt7610u-linksys-ae6000-wifi-fixes-master/os/linux' failed make[1]: *** [_module_/home/johny/Downloads/mt7610u-linksys-ae6000-wifi-fixes-master/os/linux] Error 2 make[1]: Leaving directory '/usr/src/linux-headers-4.15.0-20-generic' Makefile:394: recipe for target 'LINUX' failed make: *** [LINUX] Error 2
Hope it could be fix soon

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants