Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use auto as return type and optimize in _dimensions_from_output #40

Merged
merged 1 commit into from
Nov 15, 2018
Merged

use auto as return type and optimize in _dimensions_from_output #40

merged 1 commit into from
Nov 15, 2018

Conversation

marty1885
Copy link
Contributor

Some optimizations and clean up I came across when trying to implement #37

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.597% when pulling 968a36f on marty1885:master into 90c513c on egpbos:master.

@marty1885
Copy link
Contributor Author

@egpbos May you spend a minute to review this PR?

@egpbos egpbos merged commit e167f40 into xtensor-stack:master Nov 15, 2018
@egpbos
Copy link
Member

egpbos commented Nov 15, 2018

Looks great, I thought I had already merged it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marty1885 @coveralls @egpbos