Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark 1,2,3-dimensional functions against general n-dim ones #13

Open
egpbos opened this issue Oct 16, 2017 · 1 comment
Open

Benchmark 1,2,3-dimensional functions against general n-dim ones #13

egpbos opened this issue Oct 16, 2017 · 1 comment

Comments

@egpbos
Copy link
Member

egpbos commented Oct 16, 2017

We should benchmark whether the 1-3 dimensional special functions are actually faster than the n-dimensional one. If not, we can just use one implementation function for all ranks, with simple wrappers for the 1, 2 and 3 dimensional cases. This would reduce the number of implemented functions from 72 to 18, plus 54 simple wrapper functions.

egpbos added a commit that referenced this issue Oct 16, 2017
Results on my laptop: they perform exactly the same! That means we could get rid of all the special 1, 2 and 3 dimensional functions, which will clear up the code a lot.
@egpbos
Copy link
Member Author

egpbos commented Oct 16, 2017

See commit message above; the general n-dimensional functions in the current simple numpy-like interface are exactly the same! Will have to test more with more high-performance planner flags, though (#7).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant