Generic, simple implementation fox xsimd::compress #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@avitase : current generic implementation probably under-performs, I'll check that :-) |
serge-sans-paille
force-pushed
the
feature/compress
branch
from
4222a13
to
440df69
Compare
|
faster generic version! I'll add an AVX512 version at the end of the day. |
|
@luhenry : out of curiosity, is there a specific riscv instruction that could help here? I'm fine with keeping the generic implementation for riscv (just like for arm and wasm) but I'm just curious. |
|
@serge-sans-paille probably the vcompress.vm instruction. See https://github.com/riscv/riscv-v-spec/blob/fc76ec73fc1dd4531360ee8f3138f79f02e8b1b0/v-spec.adoc#165-vector-compress-instruction for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #975