Provide a generic version for float to uint32_t conversion #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| batch<float, A> cnst65536f(65536.0f); | ||
|
|
||
| auto v_lo = batch_cast<int32_t>(v & msk_lo); /* extract the 16 lowest significant bits of self */ | ||
| auto v_hi = batch_cast<int32_t>(v >> 16); /* 16 most significant bits of v */ |
There was a problem hiding this comment.
I'm a bit confused here; fast_cast is supposed to be called by the generic batch_cast when a fast cast is available. Replacing the implementation specific to instruction sets with this generic one would end in calling the "slow" batch cast, right? Or am I missing sometihng?
There was a problem hiding this comment.
Yes I was thinking along the same lines. Can we replace specific implementations with a generic one ?
There was a problem hiding this comment.
Indeed, I've adjusted the generic conversion to only be selected if we have a fast conversion from int32 to float.
serge-sans-paille
force-pushed
the
feature/syndicate-fast-cast-code
branch
from
da727e3
to
31f7616
Compare
…he int32 conversion is available This remove duplicate code for various Intel implementation and should also help for #962.
serge-sans-paille
force-pushed
the
feature/syndicate-fast-cast-code
branch
from
31f7616
to
f9dcafb
Compare
JohanMabille
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This remove duplicate code for various Intel implementation and should also help for #962.