Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect nodeVersion: false option #762

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Respect nodeVersion: false option #762

merged 1 commit into from
Jul 23, 2024

Conversation

fregante
Copy link
Member

@fregante fregante commented Jul 23, 2024 •
edited
Loading

This is confirmed to fix the issue. Also I was able to verify that setting nodeVersion: "20" in an override restores the node-related rules.

@fregante fregante mentioned this pull request Jul 23, 2024
Merged
@sindresorhus sindresorhus merged commit c965843 into main Jul 23, 2024
4 checks passed
@sindresorhus sindresorhus deleted the accept-nodeVersion-false branch July 23, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nodeVersion: false doesn't disable the related rules
2 participants
@fregante @sindresorhus