Don't destroy plugins. #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `esnext` option is `false`, we currently blow away existing plugins, replacing it with only the `babel` plugin. This prepends it. This does not come with a test, as option handling is currently pretty difficult. We can add the appropriate test for this there. Reference: xojs#58 (comment)
|
Thank you @jamestalmage for noticing this :D |
sindresorhus
referenced
this pull request
Dec 15, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
esnextoption isfalse, we currently blow away existingplugins, replacing it with only the
babelplugin. This prepends it.This does not come with a test, as option handling is currently pretty difficult.
We can add the appropriate test for this there.
Reference:
#58 (comment)