Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name issue with invalid characters in @builtin/xrepo #5702

Closed
xq114 opened this issue Oct 10, 2024 · 1 comment
Closed

Name issue with invalid characters in @builtin/xrepo #5702

xq114 opened this issue Oct 10, 2024 · 1 comment
Milestone

Comments

@xq114
Copy link
Contributor

xq114 commented Oct 10, 2024

          这里实现还是有问题,当加的变量比较复杂(比如路径)
xrepo_addenv("CMAKE_PREFIX_PATH", "C:\\Users\\xq114\\Downloads\\libtorch")

会报错

error: @programdir\core\main.lua:329: @programdir\modules\async\runjobs.lua:325: @programdir\core\package\package.lua:718: cannot create filelock for package(__xrepo_addenv_CMAKE_PREFIX_PATHC:\Users\xq114\Downloads\libtorch)!

去重的时候简单拼接还是不行,会有非法字符,包括xrepo_addenvs使用的table也不行,含有":"字符。理想方式是使用hash,但description scope用不了hash.md5

Originally posted by @xq114 in #5580 (comment)

@waruqi waruqi mentioned this issue Oct 10, 2024
@waruqi
Copy link
Member

waruqi commented Oct 10, 2024

试下这个 #5703

@waruqi waruqi added this to the v2.9.6 milestone Oct 10, 2024
@waruqi waruqi closed this as completed Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants