Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: CI nextest failed by timeout #907

Open
1 task done
lxl66566 opened this issue Jul 19, 2024 · 3 comments · May be fixed by #918
Open
1 task done

[Bug]: CI nextest failed by timeout #907

lxl66566 opened this issue Jul 19, 2024 · 3 comments · May be fixed by #918
Assignees
Labels
bug Something isn't working kind/flake Categorizes issue or PR as related to a flaky test.

Comments

@lxl66566
Copy link
Collaborator

lxl66566 commented Jul 19, 2024

Description about the bug

There was a case that nextest failed by timeout found on github workflow. When I reruned the code without modifing any code, the failure disappeared.
It's a rare error that cannot be reproduced stably. And It can be either the code bug or a nextest bug.

Version

0.6.1 (Default)

Relevant log output

the failed CI: https://github.com/xline-kv/Xline/actions/runs/10003614333/job/27650819920?pr=905
the success(rerun) CI: https://github.com/xline-kv/Xline/actions/runs/10003614333?pr=905
The failed test is: curp::it server::shutdown_rpc_should_shutdown_the_cluster
There're a lot of RpcTransport(()) error

Code of Conduct

  • I agree to follow this project's Code of Conduct
@lxl66566 lxl66566 added the bug Something isn't working label Jul 19, 2024
Copy link

👋 Thanks for opening this issue!

Reply with the following command on its own line to get help or engage:

  • /contributing-agreement : to print Contributing Agreements.
  • /assignme : to assign this issue to you.

@lxl66566
Copy link
Collaborator Author

lxl66566 commented Jul 26, 2024

That might caused by the following:

  • A put client opens a thread and sends 10 Put requests one by one.
  • Another client proposed shutdown to cluster
  • The putclient waits for a response, exceeding the time limit. now the cluster may have shut down successfully, and RPC closed.
  • The put client retries, and gets an RpcTransport error, keep retrying. Each put request may retry 3 times, 10.5s.
  • each 10 put request retry for at most 105s, exceed 30s test timeout.

This should be fixed when #918 merge.

@lxl66566 lxl66566 self-assigned this Jul 29, 2024
@lxl66566 lxl66566 mentioned this issue Jul 30, 2024
1 task
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 29, 2024
@liangyuanpeng liangyuanpeng added kind/flake Categorizes issue or PR as related to a flaky test. and removed Stale labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working kind/flake Categorizes issue or PR as related to a flaky test.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants