Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] refactor Xline ci process #822

Open
Phoenix500526 opened this issue May 16, 2024 · 6 comments
Open

[Refactor] refactor Xline ci process #822

Phoenix500526 opened this issue May 16, 2024 · 6 comments
Labels
good first issue Good for newcomers

Comments

@Phoenix500526
Copy link
Collaborator

The following code snippet is taken from our pull_request.yml

...
jobs:
  test:
      ...
      strategy:
        fail-fast: true
        matrix:
          config:
            - {
                name: "Normal",
                args: "",
                rustflags: "",
                test: "llvm-cov nextest --all-features --workspace --codecov --output-path codecov.info",
              }
            - {
                name: "Madsim",
                args: "--package=simulation",
                rustflags: "--cfg madsim",
                test: "nextest run --package=simulation",
              }
      name: Tests ${{ matrix.config.name }}
      steps:
         ...
         - name: Clippy ${{ matrix.config.name }}
            env:
              RUSTFLAGS: ${{ matrix.config.rustflags }}
            run: cargo clippy ${{ matrix.config.args }} --all-targets --all-features -- -D warnings
        ....
        - name: Test ${{ matrix.config.name }}
           env:
              RUSTFLAGS: ${{ matrix.config.rustflags }}
            run: cargo ${{ matrix.config.test }}
       ....

As you can see, the usage of matrix.config.args in "Clippy ${{ matrix.config.name }}" and "Test ${{ matrix.config.name }}" is different. We can do some refactor staff to make them uniform.

@Phoenix500526 Phoenix500526 added the good first issue Good for newcomers label May 16, 2024
Copy link

👋 Thanks for opening this issue!

Reply with the following command on its own line to get help or engage:

  • /contributing-agreement : to print Contributing Agreements.
  • /assignme : to assign this issue to you.

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@bhavik-goplani
Copy link
Contributor

/assignme

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 22, 2024
@bhavik-goplani
Copy link
Contributor

Working on this.

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 22, 2024
@bhavik-goplani bhavik-goplani removed their assignment Aug 30, 2024
@github-actions github-actions bot removed the Stale label Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants