Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor]: Xline logs #516

Open
bsbds opened this issue Nov 10, 2023 · 5 comments
Open

[Refactor]: Xline logs #516

bsbds opened this issue Nov 10, 2023 · 5 comments
Labels
Improvement Refactor or optimization, including process, performance or something like that

Comments

@bsbds
Copy link
Collaborator

bsbds commented Nov 10, 2023

Currently there are serveral issues in the log of Xline:

  1. Log size is huge
    During a recent Jepsen test with Xline debug level enabled, Xline printed the key-values of every command to logs. This resulted in large log files, as the values can be several tens of kilobytes in size. To address this issue, the logs should be refactored to either use the tracing level or disable the printing of key-values. Note that this issue may also be present in snapshot related logs.

  2. Logs are confusing
    The current logs are confusing as they lack essential information required for effective debugging. The logs should include key information, such as propose ID and revisions, to enable easy tracking of command execution.

@Phoenix500526 Phoenix500526 added the Improvement Refactor or optimization, including process, performance or something like that label Nov 22, 2023
@Phoenix500526 Phoenix500526 added this to the v0.7.0 milestone Nov 22, 2023
@Phoenix500526
Copy link
Collaborator

Refer to #683

@rohansx
Copy link

rohansx commented Mar 13, 2024

@bsbds would like to take on this task

@Phoenix500526
Copy link
Collaborator

Hi, @rohansx , would you like to take on this issue?

@rohansx
Copy link

rohansx commented Mar 17, 2024

@Phoenix500526 Yeah sure i can give it a try

@Phoenix500526
Copy link
Collaborator

Hi,@rohansx, I'm glad you're interested in this issue. However, I believe there are some ambiguous points in the issue description, such as how to define the so-called "essential information" in point 2. This may require a deep understanding of the entire project and experience in debugging. IMO, starting with the first point would be relatively easier as a starting point. @bsbds can you give some information for the point two?

@bsbds bsbds removed this from the v0.7.0 milestone Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Refactor or optimization, including process, performance or something like that
Projects
None yet
Development

No branches or pull requests

3 participants