-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows build issues #7
Comments
Correct and by-design.
Because I don't know a good way to solve all below together:
Suggestions wanted.
What do you mean by initialized? Follow version mapping here in case you need: https://developer.microsoft.com/en-us/windows/downloads/sdk-archive/
It should be installed.
Export from where and find it in where?
Yes, that's why the default
This depends on GitHub behavior in different space/time, and need to be carefully tuned. Linux side I implemented a back-off strategy as part of the mirror-aware submodule cloning. Roaster/pkgs/utils/git/submodule.sh Lines 55 to 64 in 52428ec
Yes, dual-build is well supported there and there's no many dependencies.
This has been fixed with |
FYI I did a Windows build during weekend. |
I can successfully build libraries except for pytorch Will try to setup another clean machine to validate.
|
You explicitly initialized here: Roaster/win/pkgs/env/toolchain.ps1 Line 185 in 2205965
Per my understanding, the Win10 SDK version doesn't matter too much since you don't rely on any new Windows APIs. In such case, Windows SDK should have stable ABI interfaces between different versions. BTW, another suggestion is using vs command line to install SDKs. It's incrementally installed and you don't need to keep the SDK links either.
It's my mistake. I didn't notice that you'll use
In my initial trials, CMake complained that it couldn't locate zlib or openssl (I manually executed those scripts one by one). I had to manually set some envs
Yes, it worked as you described.
But we don't enable dual build in windows build. And the default build variant is
|
Ideally I'd like to install standard (maybe community since that's free?) version of VS, so that people can add things later. Is that possible to install standard VS via command line?
WINVER and all those WinSDK macros for minimum targeting platform are set to SDK version by default, and won't work on older OS.
I double checked, it is dual-build by default. |
Yes. The script would be very similar with the
Per-project setting is also something i want to avoid. But my question is we seems to install extra WinSDKs than what we really need. We actually have two kinds of cmake generators, Ninja and VS2019.
Therefore, at most two Windows SDK version will be used across windows build, but in
You're correct, it's dual build. I probably just took a glance at the build log and then thought it only build for debug variant. |
We do. It's the same as ninja build. vs generator should take what's given by the env var. Let me know if it failed to do so.
Those 4 are selected based on popularity of Win10/Win2019 versions. |
Snappy build failed again. Snappy is adding third party submodules in their repo. |
Fixed with |
Not actually. I'll provide error logs later. |
|
Confirmed. Seems to be a bug. Static lib works but we need dynamic libs. |
Thanks, this should fix the issue. BTW, why don't we use a stable release branch to build snappy? |
And I can't find the issues tab in snappy repo... =。= |
Because unit test of that one doesn't work. gtest linkage issue.
Same here. |
Here're some issues observed when building roaster packages in Windows:
toolchain.ps1
:win/pkgs/env
folder is ignored by mistake;winsdk
:10.0.16299
is initialized;cmake
:curl
built and installed;zlib
andopenssl
:freetype
andharfbuzz
:freetype
doesn't support build w/o harfbuzz;boost
:-j50
doesn't reliably clone the repo and all the submodules;release
;snappy
:latest_ver
is override tolatest
and cause build failure.The text was updated successfully, but these errors were encountered: