Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: add warning for missing Xvfb #478

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Test: add warning for missing Xvfb #478

merged 1 commit into from
Apr 16, 2024

Conversation

wismill
Copy link
Member

@wismill wismill commented Mar 25, 2024

Closes #477.

@wismill
Copy link
Member Author

wismill commented Mar 25, 2024

Note: I did not require Xvfb program, but just raise a warning, because Xvfb is only needed at run time. Should we better raise an error?

@wismill
test(x11): Warn for missing Xvfb program
5257e72 
Xvfb is required for *running* X11 tests. We do not make it mandatory
in the meson setup though, because we did not find a way to require a
*run* time dependency.
bluetech
bluetech approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually don't know what is the best practice for this. I assume there are setups where the build machine and test machines are separate, but a warning seems OK to me.

@wismill wismill merged commit 11f7ef2 into xkbcommon:master Apr 16, 2024
4 checks passed
@wismill wismill deleted the test/xvfb-detection branch April 16, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluetech bluetech bluetech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.7.0: test suite fails in two units
2 participants
@wismill @bluetech