Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: remove unused #incldue <ctype.h> #461

Merged
merged 1 commit into from
Mar 7, 2024
Merged

tools: remove unused #incldue <ctype.h> #461

merged 1 commit into from
Mar 7, 2024

Conversation

bluetech
Copy link
Member

@bluetech bluetech commented Mar 1, 2024

We avoid this header due to its locale dependence. This include seems like a leftover in 4402922.

@bluetech
tools: remove unused #incldue <ctype.h>
e6f02f5 
We avoid this header due to its locale dependence. This include seems
like a leftover in 4402922.

Signed-off-by: Ran Benita <[email protected]>
@bluetech bluetech requested a review from wismill March 1, 2024 10:38
wismill
wismill approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@wismill wismill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I guess I wanted to use iscntrl but changed my mind. Not sure we need to improve the hack much with standard functions.

@bluetech bluetech merged commit abb6e58 into xkbcommon:master Mar 7, 2024
4 checks passed
@bluetech bluetech deleted the rm-unused-ctypes branch March 7, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wismill wismill wismill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bluetech @wismill