Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules: Include does not lookup context paths #501

Closed
wismill opened this issue Aug 30, 2024 · 1 comment · Fixed by #506
Closed

Rules: Include does not lookup context paths #501

wismill opened this issue Aug 30, 2024 · 1 comment · Fixed by #506
Labels
enhancement Indicates new feature requests rules

Comments

@wismill
Copy link
Member

wismill commented Aug 30, 2024

Contrary to keymap files, the ! include statement in rules does not lookup include paths added to xkb_context. So it is not possible e.g. to import another file in the same folder without using an absolute path.

I know the first intended use is using system path, e.g. ! include %S/evdev (see #108), but I expected to be able to use the statement as the keymap one.

My current use case is to be able to modify the rules for the tests in #450 without duplicating the whole rule file. I want to be able to use ! include evdev and resulting in including the first file named rules/evdev found in the xkb_context include paths. Meanwhile I defined XKB_CONFIG_ROOT and used %S.

Apart from that, this is for consistency with the rest of the lib. So low priority.


PS: I did not realize that ! include is not supported by XOrg tools. Might be worth added a note in the compatibility page and in the rule file page.

@wismill wismill added enhancement Indicates new feature requests rules labels Aug 30, 2024
@whot
Copy link
Contributor

whot commented Sep 15, 2024

PS: I did not realize that ! include is not supported by XOrg tools. Might be worth added a note in the compatibility page and in the rule file page.

Too many different tools, all need to be updated (and know that the next level supports it). Yay the Unix way! Too much effort for the gain.

So it is not possible e.g. to import another file in the same folder without using an absolute path.

That definitely sounds like a bug to me, so adding that would get my ack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates new feature requests rules
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants