Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key_frame_interval capi option inconsistently named with cli #3267

Open
tdaede opened this issue Oct 17, 2023 · 0 comments
Open

key_frame_interval capi option inconsistently named with cli #3267

tdaede opened this issue Oct 17, 2023 · 0 comments
Labels

Comments

@tdaede
Copy link
Collaborator

tdaede commented Oct 17, 2023

The options for keyframe interval via capi are named "key_frame_interval" and "min_key_frame_interval", but this does not match either the cli (which is "keyint and "min_keyint"), nor the config struct (which is "max_key_frame_interval" and "min_key_frame_interval", and has different semantics regarding max = 0).

Given the semantics we should probably accept the CLI names of these parameters.

Version:

rav1e 0.6.6 (UNKNOWN) (release)
Compiled CPU Features: fxsr,sse,sse2
Assembly: Enabled
Threading: Enabled
Unstable Features: Enabled
Compiler Flags: -Copt-level=3-Cdebuginfo=2-Ccodegen-units=1-Cstrip=none-Cforce-frame-pointers=yes-Clink-arg=-Wl,-z,relro-Clink-arg=-Wl,-z,now-Clink-arg=-specs=/usr/lib/rpm/redhat/redhat-package-notes--cap-lints=warn
@tdaede tdaede added the bug label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant