Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for python 3.11 #68

Merged
merged 7 commits into from
Feb 22, 2024
Merged

Add support for python 3.11 #68

merged 7 commits into from
Feb 22, 2024

Conversation

jbusecke
Copy link
Contributor

@jbusecke jbusecke commented Oct 26, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31fa4c7) 90.03% compared to head (f936f1c) 90.03%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #68   +/-   ##
=======================================
  Coverage   90.03%   90.03%           
=======================================
  Files           7        7           
  Lines         251      251           
=======================================
  Hits          226      226           
  Misses         25       25           
Flag Coverage Δ
unittests 90.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbusecke
Copy link
Contributor Author

Lets see if 3.12 works as well?

@jbusecke
Copy link
Contributor Author

3.12 does not seem to work (just stupidly created a dupe #74 and fails with

Obtaining file:///home/runner/work/aerobulk-python/aerobulk-python
  Preparing metadata (setup.py): started
  Preparing metadata (setup.py): finished with status 'error'
  error: subprocess-exited-with-error
  
  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [7 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/home/runner/work/aerobulk-python/aerobulk-python/setup.py", line 7, in <module>
          import numpy.distutils.command.sdist  # noqa
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      ModuleNotFoundError: No module named 'numpy.distutils'
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

On first glance this seems like something in numpy has changed in recent versions? This def needs some deeper investigation.

This was referenced Feb 22, 2024
@jbusecke
Copy link
Contributor Author

I added "<3.12" to python_requires to pin python during install for now. We will have to address 3.12 separately in #75

@jbusecke jbusecke marked this pull request as ready for review February 22, 2024 17:44
@jbusecke jbusecke merged commit fa3ab84 into main Feb 22, 2024
7 checks passed
@jbusecke jbusecke deleted the py311 branch February 22, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant