Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fixes including CA-381728, CA-381618, CA-381225 #3205

Merged
merged 6 commits into from
Aug 21, 2023

Conversation

kc284
Copy link
Contributor

@kc284 kc284 commented Aug 21, 2023

Please review each commit separately.

… state so.

Also, livepatches should be shown if other guidance is absent.

Signed-off-by: Konstantina Chremmou <[email protected]>
Also removed scripts that are not used any more.

Signed-off-by: Konstantina Chremmou <[email protected]>
@kc284 kc284 self-assigned this Aug 21, 2023
@kc284 kc284 added the ASAP PR should be reviewed as soon as possible label Aug 21, 2023
Branding/branding.sh Show resolved Hide resolved
@CitrixChris CitrixChris added needs answer PR contains question that needs to be answered 1 approval PR has been approved by one reviewer and removed needs answer PR contains question that needs to be answered labels Aug 21, 2023
Copy link
Contributor

@CitrixChris CitrixChris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPDATES_URL form branding.sh needs removing

@kc284 kc284 added the updated Changes completed, please review label Aug 21, 2023
@danilo-delbusso danilo-delbusso added needs updating A reviewer has requested changes and removed 1 approval PR has been approved by one reviewer labels Aug 21, 2023
@danilo-delbusso danilo-delbusso added 2 approvals PR has been approved by two reviewers and removed needs updating A reviewer has requested changes updated Changes completed, please review labels Aug 21, 2023
@CitrixChris CitrixChris merged commit de1120f into xenserver:master Aug 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 approvals PR has been approved by two reviewers ASAP PR should be reviewed as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants