Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to contribute to install.sh? #64

Open
stormi opened this issue Jun 5, 2019 · 6 comments
Open

How to contribute to install.sh? #64

stormi opened this issue Jun 5, 2019 · 6 comments

Comments

@stormi
Copy link
Contributor

stormi commented Jun 5, 2019

The install.sh script from Citrix Hypervisor's guest tools ISO does not seem to be available on github. I'd like to contribute a fix that was contributed to me by a user of XCP-ng, but I don't know how.

@minli1
Copy link
Member

minli1 commented Jun 6, 2019

Hi, this script is not located in source repo. Actually, we put it when packaging.
Could you please comment where is the specific fix? Thank you.

@stormi
Copy link
Contributor Author

stormi commented Jun 6, 2019

There's no way you could make it part of the repo and use it from there when packaging?

Anyway, here's the patch. I'm waiting for the user who reported the bug to test it.

xcp-ng@c8625f1

@minli1
Copy link
Member

minli1 commented Jun 10, 2019

I checked the patch and luckily we have log an issue and the fixing/testing in progress. I think it will be released soon.
BTW, I will create an improvement ticket to move the install script to code repo anyway.
Thank you.

@stormi
Copy link
Contributor Author

stormi commented Feb 8, 2021

Hi. I'm currently trying to repackage the tools. Have things moved on towards the migration of the install script to this repo?

@xihuan-citrix
Copy link
Collaborator

Hi @stormi ,
We are going to move install.sh into this repo soon, we have a task internal to track this.

@stormi
Copy link
Contributor Author

stormi commented Jan 31, 2023

Hi @stormi , We are going to move install.sh into this repo soon, we have a task internal to track this.

Hi! This was two years ago. Is it still planned soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants