You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current implementation of xe-linux-distribution, based on sed, is rather fragile and often ends in that kind of error when the distro is unsupported:
Hmm, actually the error above probably only happens when it's trying an invalid pattern. The normal behaviour is to return nothing.
So it's less fragile than what I thought, but can easily be broken by future changes to the script. One just needs to add one invalid pattern somewhere, and this is not easily spotted during a PR review.
The current implementation of
xe-linux-distribution
, based on sed, is rather fragile and often ends in that kind of error when the distro is unsupported:We should implement the pattern matching in a more robust way while still portable of course.
I may give it a try sometime in the future...
The text was updated successfully, but these errors were encountered: