Support communicating with Xen API over TLS (#85) #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chqr
changed the title
chqr
changed the title
|
@chqr - thanks for the PR. Rather than make the user specify the full URL, do you not just need to be able to configure between using HTTP/HTTPS? I think having a protocol value default to HTTP which can be overiden might be nice from a config perspective. What do you think? |
|
@rdobson You are right, since there is existing configuration option called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds two new config flags:
remote_url: url to use when connecting to the Xen API (defaults tohttp://{remote_host})remote_url_tls_skip_verify: disables certificate verification forremote_urlI've added the second option because we are using self-signed certs on some of our our Xen servers (there are plans to fix this soon), but it could also be useful for others during testing/evaluation.