Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VLAN configuration for --network_(device|config) should be reworked #32

Open
ydirson opened this issue Jan 11, 2023 · 0 comments
Open

Comments

@ydirson
Copy link
Contributor

ydirson commented Jan 11, 2023

While working on LACP bonding support, I realize that VLAN configuration on cmdline allows some non-sensical configurations like:

--network_device=all --network_config=dhcp:vlan=10

Also "just specifying a VLAN on a given interface" requires today to repeat the dhcp default with no good reason:

--network_device=eth0 --network_config=dhcp:vlan=10

I think we should move the VLAN specification to the --network_device option, like

--network_device=eth[:vlan=VLAN]|mac[:vlan=VLAN]|all

The "just specifying a VLAN on a given interface" usecase will then become:

--network_device=eth0:vlan=10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant